fix: sync packages if "hermit install" fails to find a package #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occasionally breaks enabling the hermit IntelliJ plugin that installs dependencies automatically at startup. We also skipt the test if we had synchronized previously if we are forcing a sync. This is needed as "hermit install" does a non forced sync at the beginning, marking source as synced, and this prevents the later forced sync from running when the package is not found.
alecthomas
approved these changes
May 15, 2024
spicykay
pushed a commit
to spicykay/hermit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Liam Nattrass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occasionally breaks enabling the hermit IntelliJ plugin that installs dependencies automatically at startup.
We also skipt the test if we had synchronized previously if we are forcing a sync. This is needed as "hermit install" does a non forced sync at the beginning, marking source as synced, and this prevents the later forced sync from running when the package is not found.
Fixes #363