config: Support opting into GitHub token auth #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new per-project configuration to hermit.hcl
allowing opting GitHub owner/repo patterns to opt into
token-based authentication instead of anonymous.
For example:
github-auth-token {
match = ["cashapp/*"]
}
The option accepts any number of glob patterns,
allowing for fine-grained control over which dependencies
get authenticated requests.
This will make it possible to use Hermit with private repositories
without distributing a custom build.
The plumbing for this required a small amount of refactoring:
The new hermit.LoadEnvInfo inspects a Hermit environment
and loads the configuration, but does not open the environment.
The information is later passed to the old hermit.OpenEnv function.
This separation is necessary because cache and state are inputs to
OpenEnv, but we need to inspect the environment configuration to decide
on their inputs.
Resolves cashapp#406
alecthomas
approved these changes
Jun 21, 2024
| @@ -275,40 +283,67 @@ func readConfig(configFile string) (*Config, error) { | |||
| return config, nil | |||
| } | |||
|
|
|||
| // EnvInfo holds information about the current Hermit environment. | |||
| type EnvInfo struct { | |||
|
Thanks! |
abhinav
added a commit
to abhinav/hermit
that referenced
this pull request
Jun 21, 2024
PR cashapp#409 added support for opting packages into GitHub token authentication with a `github-token-auth` block in `bin/hermit.hcl`. This adds information about this feature to the private releases documentation, and adds an entry to the config reference.
spicykay
pushed a commit
to spicykay/hermit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new per-project configuration to hermit.hcl
allowing opting GitHub owner/repo patterns to opt into
token-based authentication instead of anonymous.
For example:
The option accepts any number of glob patterns,
allowing for fine-grained control over which dependencies
get authenticated requests.
This will make it possible to use Hermit with private repositories
without distributing a custom build.
The plumbing for this required a small amount of refactoring:
The new hermit.LoadEnvInfo inspects a Hermit environment
and loads the configuration, but does not open the environment.
The information is later passed to the old hermit.OpenEnv function.
This separation is necessary because cache and state are inputs to
OpenEnv, but we need to inspect the environment configuration to decide
on their inputs.
Resolves #406