Add support for macro conditions to named enums #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
force-pushed
the
skorulis/conditional-enums
branch
from
78088be to
254ac4c
Compare
skorulis-ap
commented
Feb 12, 2025
| extension DeclSyntaxProtocol { | ||
|
|
||
| // Wrap the declaration in an #if where needed | ||
| func maybeWithCondition(ifConfigCondition: ExprSyntax?) -> DeclSyntaxProtocol { |
There was a problem hiding this comment.
This helper prevents some duplication
skorulis-ap
commented
Feb 12, 2025
|
|
||
| extension NamedRegistrationGroup { | ||
| // Generate the enum for this group of named registrations | ||
| func enumSourceCode(assemblyName: String) throws -> DeclSyntaxProtocol { |
There was a problem hiding this comment.
I moved this out of TypeSafetySourceFile to make this code easier to test in isolation.
skorulis-ap
force-pushed
the
skorulis/conditional-enums
branch
from
254ac4c to
406686c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#ifcondition then the resolver and the enum are both wrapped in the same condition.#ifconditions, the resolver will not have a condition and the enum cases will be wrapped in#ifconditions from the individual registrations.