feat: smarter indentation detection. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably a bit on the expensive side, but I think it's a bit more intuitive to use than SmartIndent.
autonomousapps
commented
Jul 15, 2024
| * discovered is the common indent level. If no indent discovered (which could happen if this | ||
| * input contains only top-level statements), defaults to [min]. | ||
| */ | ||
| public fun computeIndent( |
There was a problem hiding this comment.
I don't really like this function because it feels like a poor man's regex, and the whole point of creating a parse tree is avoiding regex -- nonetheless, dealing with whitespace has proven to be a huge pain, this works, and I think we ought to be able to further improve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a bit on the expensive side, but I think it's a bit more intuitive to use than SmartIndent.
It's more intuitive because users don't have to call
setIndent()in one of the listener functions (failing to do this is very common). They can simply get the indentation level when instantiating their listeners.