Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting latin1 to utf8 charset checksum failures #373

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

morgo
Copy link
Collaborator

@morgo morgo commented Feb 15, 2025

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.
Further notes in https://github.com/cashapp/spirit/blob/main/.github/CONTRIBUTING.md

Fixes #372

@morgo morgo requested a review from Copilot February 15, 2025 17:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (3)
  • pkg/dbconn/sqlescape/utils_test.go: Evaluated as low risk
  • pkg/table/chunker_composite.go: Evaluated as low risk
  • .golangci.yaml: Evaluated as low risk

@morgo morgo requested a review from prudhvi February 15, 2025 17:18
@morgo morgo merged commit ef33b31 into cashapp:main Feb 15, 2025
6 checks passed
@morgo morgo deleted the convert-charset branch February 15, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting charset from latin1 to utf8mb4 can fail checksum
2 participants