Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose lock name on spirit side - clients acquiring locks can get to know their exact lock name #374

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

Kiran01bm
Copy link
Collaborator

Change Summary

Compose lockName on the spirit side - improved logging and also exporting the lockName so clients acquiring locks can get to know their exact lockName. Migration Runner test is one such client.

Local tests have passed ✅.

@Kiran01bm Kiran01bm force-pushed the compose-lockname-on-client branch from 43e42a7 to a2f2f4e Compare February 17, 2025 21:31
@morgo morgo requested a review from kolbe February 17, 2025 23:58
Copy link
Collaborator

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kiran01bm Kiran01bm merged commit 76c1998 into cashapp:main Feb 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants