Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix option parsing #378

Merged
merged 2 commits into from
Feb 22, 2025
+3 −10
Merged

fix option parsing #378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf553ca
fix option parsing
morgo Feb 22, 2025
9da9491
fix buildandrun script, remove unused
morgo Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions USAGE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ go build
### alter

- Type: String
- Default value: `engine=innodb`
- Examples: `add column foo int`, `add index foo (bar)`

The alter table command to perform. The default value is a _null alter table_, which can be useful for testing.
Expand Down Expand Up @@ -136,7 +135,6 @@ When set to `TRUE`, if Spirit encounters a checkpoint belonging to a previous mi
### table

- Type: String
- Default value: `stock`

The table that the schema change will be performed on.

Expand Down
4 changes: 2 additions & 2 deletions pkg/migration/migration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ type Migration struct {
Username string `name:"username" help:"User" optional:"" default:"msandbox"`
Password string `name:"password" help:"Password" optional:"" default:"msandbox"`
Database string `name:"database" help:"Database" optional:"" default:"test"`
Table string `name:"table" help:"Table" optional:"" default:"stock"`
Alter string `name:"alter" help:"The alter statement to run on the table" optional:"" default:"engine=innodb"`
Table string `name:"table" help:"Table" optional:""`
Alter string `name:"alter" help:"The alter statement to run on the table" optional:""`
Threads int `name:"threads" help:"Number of concurrent threads for copy and checksum tasks" optional:"" default:"4"`
TargetChunkTime time.Duration `name:"target-chunk-time" help:"The target copy time for each chunk" optional:"" default:"500ms"`
ForceInplace bool `name:"force-inplace" help:"Force attempt to use inplace (only safe without replicas or with Aurora Global)" optional:"" default:"false"`
Expand Down
Loading