New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix --statement bugs #379

Merged

morgo merged 1 commit into cashapp:main from morgo:mtocker-fix-statement-bugs

Feb 24, 2025

Collaborator

morgo commented Feb 24, 2025

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.
Further notes in https://github.com/cashapp/spirit/blob/main/.github/CONTRIBUTING.md

There are a few bugs in #375

Attempting as INSTANT or INPLACE doesn't work when --statement is used. This is because it depends on the --alter specified by the user, and not the stmt.Alter. For consistency I've unified Alter and Schema to come from stmt.
Extracting the ALTER portion of an alter statement was inaccurate when the schema name was specified.


          fix --statement bugs

dd2cdf3

morgo requested a review from kolbe

February 24, 2025 15:16

kolbe approved these changes

View reviewed changes

morgo merged commit c80bee9 into cashapp:main

6 checks passed

morgo deleted the mtocker-fix-statement-bugs branch

February 24, 2025 17:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet