Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support wasm #290

Merged
merged 2 commits into from
Feb 16, 2024
Merged

[FEAT] Support wasm #290

merged 2 commits into from
Feb 16, 2024

Conversation

ahna92
Copy link
Contributor

@ahna92 ahna92 commented Dec 24, 2023

No description provided.

@JakeWharton
Copy link
Collaborator

Once a stable version of coroutines is out we'd be happy to mirror their new targets.

@ahna92
Copy link
Contributor Author

ahna92 commented Dec 24, 2023

@JakeWharton sure 👍 , is it possible to get an alpha/canary version with this change ?

@JakeWharton
Copy link
Collaborator

I'm on paternity leave and it's the holidays. I also don't want to really set a precedent. We can merge it and you can consume the snapshot. I'll look tomorrow.

@ahna92
Copy link
Contributor Author

ahna92 commented Dec 24, 2023

@JakeWharton nothing urgent, if it's a click of button let's have it , if not just enjoy the holidays ! can look at this next year :D

@faogustavo
Copy link

Now that Coroutines 1.8.0 is stable and merged into the trunk, would you be able to move forward with this? :)

@JakeWharton
Copy link
Collaborator

Yes. Please rebase. Do they only support wasmJs or was wasmWasi also included?

@faogustavo
Copy link

Looks like only WasmJS.

@JakeWharton JakeWharton enabled auto-merge (squash) February 16, 2024 19:17
@JakeWharton JakeWharton merged commit f0e47bf into cashapp:trunk Feb 16, 2024
1 check passed
ZacSweers added a commit to slackhq/circuit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants