Draft for discussion: on sending a signal when networking fails

cashapp · Jan 10, 2024 · 14e1d91 · 14e1d91
1 parent f1a2f74
commit 14e1d91
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/zipline-loader/src/commonMain/kotlin/app/cash/zipline/loader/ZiplineLoader.kt b/zipline-loader/src/commonMain/kotlin/app/cash/zipline/loader/ZiplineLoader.kt
@@ -45,6 +45,7 @@ import kotlinx.coroutines.withContext
 import kotlinx.serialization.modules.EmptySerializersModule
 import kotlinx.serialization.modules.SerializersModule
 import okio.FileSystem
+import okio.IOException
 import okio.Path
 
 /**
@@ -182,7 +183,10 @@ class ZiplineLoader internal constructor(
       }
       manifestUrlFlow.collect { manifestUrl ->
         if (previousManifest != null &&
-          freshnessChecker.isFresh(previousManifest!!, previousManifest!!.freshAtEpochMs ?: Long.MIN_VALUE)
+          freshnessChecker.isFresh(
+            previousManifest!!,
+            previousManifest!!.freshAtEpochMs ?: Long.MIN_VALUE
+          )
         ) {
           return@collect
         } else {
@@ -281,6 +285,9 @@ class ZiplineLoader internal constructor(
       // If emit() threw a CancellationException, consider that emit to be successful.
       // That's 'cause loadOnce() accepts an element and then immediately cancels the flow.
       throw e
+    } catch (e: IOException) {
+      send(LoadResult.Failure(e))
+      return null
     } catch (e: Exception) {
       eventListener.applicationLoadFailed(applicationName, manifestUrl, e, startValue)
       if (loadedManifest != null) {