Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CashuAuthMint #245

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Cleanup CashuAuthMint #245

merged 1 commit into from
Feb 4, 2025
+5 −162

Conversation

Egge21M
Copy link
Collaborator

@Egge21M Egge21M commented Feb 4, 2025

Description

This PR leans down the CashuAuthWallet class by removing unnecessary options and streamlining output creating using the new OutputData class.

Changes

  • Removed counter & seed
  • Removed split, denomination target, outputAmounts
  • Removed most of the output logic and replaced it with very simple call to OutputData

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

@Egge21M Egge21M merged commit 9586760 into auth Feb 4, 2025
4 checks passed
@Egge21M Egge21M deleted the auth-cleanup branch February 4, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callebtc callebtc callebtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Egge21M @callebtc