Apply changes from https://github.com/casper-network/casper-node/pull/5089 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-casper
approved these changes
Feb 5, 2025
|
@igor-casper @zajko Is there a process to update files in resources/examples/ ? thanks |
gRoussac
force-pushed
the
binary_response_changes
branch
from
bf2f46a to
3fa4b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply changes from casper-network/casper-node#5089
Missing : Update of example files
resources/examples/*.binGetting request_id from
BinaryResponseAndRequestrequest is a bit strange, I would have expected not to have to extract the request id from the request but have it inBinaryResponseHeader