DE-7860: Display all timeline cues #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingerartur
reviewed
Sep 4, 2025
fingerartur
requested changes
Sep 4, 2025
Contributor
fingerartur
left a comment
fingerartur
left a comment
There was a problem hiding this comment.
Good but let's make this more generic 👍
gajdusep
force-pushed
the
fix/DE-7860-ui-cues-filter
branch
from
4296708 to
499ce59
Compare
gajdusep
changed the title
Until now, we were showing only cues with schemeIdUri com.apple.hls.interstitial, but some cues do not have this attribute. We remove the condition here to show all timeline cues. The filter for pre and post cues is kept.
gajdusep
force-pushed
the
fix/DE-7860-ui-cues-filter
branch
from
499ce59 to
a950819
Compare
fingerartur
reviewed
Sep 4, 2025
fingerartur
approved these changes
Sep 4, 2025
Co-authored-by: Artur Finger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we were showing only cues with
schemeIdUricom.apple.hls.interstitial, but some cues do not have this attribute.We remove the condition here to show all timeline cues.
The filter for pre and post cues is kept.