Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server selection on initialize-archiver clearer #580

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Feb 5, 2025

Overview

What problem does this address?
Makes the choice of server more obvious in initialize-archiver

What did you change in this PR?

  • Switch from boolean to choice in github action

Testing

How did you make sure this worked? How can a reviewer verify this?
Run the action on this branch for both production and sandbox servers.
Sandbox: https://github.com/catalyst-cooperative/pudl-archiver/actions/runs/13168342804/job/36753639628
Prod: https://github.com/catalyst-cooperative/pudl-archiver/actions/runs/13168368880/job/36753714104

To-do list

Tasks

Preview Give feedback

@e-belfer e-belfer added github_actions Pull requests that update GitHub Actions code automation Issues relating to automated archiver runs labels Feb 5, 2025
@e-belfer e-belfer self-assigned this Feb 5, 2025
@e-belfer e-belfer requested a review from zaneselvans February 5, 2025 23:15
Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestion to use sandbox as the default.

.github/workflows/initialize-archiver.yml Outdated Show resolved Hide resolved
@e-belfer e-belfer merged commit 94ec298 into main Feb 6, 2025
3 checks passed
@e-belfer e-belfer deleted the update-sandbox-selector branch February 6, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Issues relating to automated archiver runs github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants