Improve the handling of separation between window title and status #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-xella
commented
Aug 3, 2024
j-xella
commented
- Before, it was always separated by space, now the separator can be changed or removed via global option
- Now, the separator is only added if there is an actual status to display. Works for custom separator icons only.
added 2 commits
August 4, 2024 01:26
Backward-compatible change, allows adding separators before or after the option value if the option is not empty.
The default space separator in front of the status icons can now be removed, or changed to something else. Also, the separator logic is now enhanced; the separator is only added if the status icon is not empty. Unfortunately, it does not work with status as text, because the value is not available yet when the separator is added.
|
This is a decision made by the theme, see #168 |
|
OK, understood, the theme wants window status indicators always separated by spaces. But this PR also has another part to it, a bug fix IMHO. Similar to what #265 does to status modules. Let's say user sets active window icon to null. Then the icon is not shown, but the separator space is added nevertheless to the window info. IMO, there should be no separator if status icon is removed, correct? Would this PR be considered if only that part is left? |
|
if you can find a could way to remove the space if it's empty yes, without changing Best way I could come up with is using this |
|
Please see #270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.