-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(status): use @catppuccin_status_background as background color #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to make a PR!
Are you fixing a specific bug? And/or do you have before and after screenshots?
Why is default wrong? I agree that hardcoding surface 1 should probably change.
Also where did ${CTP_MESSAGE_BACKGROUND}
come from? Where is that environment variable set?
I want the status bar to have a consistent color, when setting Before After The variable But maybe it is better to change the hardcoded |
Not sure if it's related, but since 0.4 I can't seem to get transparent background to work. It's one of the reasons I've pinned to 0.3. @dreknix Can you share your tmux.conf for that layout? I couldn't migrate to 0.4 successfully. |
Yep sounds reasonable.
Ah that's meant to be local and not exported.
What happens if you use default? The status line is already styled, I don't want to duplicate that if possible |
Here is my minimal
|
Ok, good to know.
When I use Since |
I changed the PR to use a new variable
Thanks a lot for the discussion and the great plugin. |
Thank you so much! |
…atppuccin#367) * style(status): use @catppuccin_status_background as background color * fix: color must be expanded for test cases * fix: color must be expanded for test cases * Update catppuccin_options_tmux.conf * Reuse @catppuccin_status_background to determine the correct status line background color --------- Co-authored-by: Christoph Weyer <[email protected]> Co-authored-by: Kaley Main <[email protected]> Co-authored-by: Kaley Main <[email protected]>
When changing the background of the status bar, I think the default background color of all modules should be this color.
Therefore, the hard coded references to
default
andthm_surface_1
inutils/status_module.conf
should be in my opinion changed to${CTP_MESSAGE_BACKGROUND}
. With this changes the background color of the status bar is always the same.I'm not so familiar with the new tmux configuration style. I hope that this is the correct way to solve the problem.