Python3 support #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- With standarts from github gitignores repo - Add .vscode/ - Move to root repo folder
- Python 3 is regarded as the future of the language so it _should_ be prefered - Cleaner usage of requests: changed json.loads(u._content) to the more clean usage u.json()
- https://ifconfig.co does not give the ip only. https://ifconfig.co/ip does.
- Logger can be configured in the config file - Added an working example config in the example file
- Added verbosity function using the debug level in logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 support (and logging and verbosity function)
json.loads(u._content)to the more clean usageu.json()Update .gitignore
Added proper logging to console and a file
Added verbosity function
Python 2 still works