Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format essnmx #780

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

format essnmx #780

wants to merge 4 commits into from

Conversation

aaronfinke
Copy link

update for format essnmx

@ndevenish
Copy link
Collaborator

Are the now-commented out code blocks useful to keep around? I'd rather remove them and use the file history if it's just a reference to the way it used to work.

Also, could you add a newsfragments/780.feature text file with a brief description of the change? And also add yourself to AUTHORS?

@aaronfinke
Copy link
Author

Are the now-commented out code blocks useful to keep around? I'd rather remove them and use the file history if it's just a reference to the way it used to work.

Yes, the format is constantly changing (for now) so it's useful to keep that code just in case. I will remove it when the format is solifidied.

Also, could you add a newsfragments/780.feature text file with a brief description of the change? And also add yourself to AUTHORS?

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants