-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ switch to mqt-core
Python package
#418
Open
burgholzer
wants to merge
36
commits into
main
Choose a base branch
from
mqt-core-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57479ce
to
e05f117
Compare
This was referenced Jan 27, 2024
Merged
burgholzer
added a commit
that referenced
this pull request
Jan 29, 2024
## Description This PR updates the mqt-core submodule and brings in some further advancements from #418. Specifically, it switches to using `FetchContent` for obtaining `mqt-core` (and `LogicBlocks`). Per default, it is pointed to the vendored submodule via an overridable CMake variable. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
2643b7b
to
c93369f
Compare
c93369f
to
07e035d
Compare
4 tasks
07e035d
to
87a5ae8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=====================================
Coverage 90.7% 90.8%
=====================================
Files 93 94 +1
Lines 10763 10762 -1
Branches 1830 1831 +1
=====================================
+ Hits 9772 9780 +8
+ Misses 991 982 -9
|
4 tasks
87a5ae8
to
dbaa9cb
Compare
4 tasks
73c1693
to
f7d2f1d
Compare
4 tasks
burgholzer
added a commit
to cda-tum/mqt-core
that referenced
this pull request
Jan 22, 2025
## Description This PR fixes an oversight in #753 where the respective changes would sometimes create invalid output permutation dumps. This surfaced as part of cda-tum/mqt-qmap#418. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>
f7d2f1d
to
496364f
Compare
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
This is mostly to avoid a naming conflict on editable installs because the `src/mqt/qmap` directory contained a subdirectory `qiskit`. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
given how the output was never displayed correctly anyways, this might as well be removed from the docs. That way, we do not need graphviz as well. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
the patch will now also check for Z3 in site-packages similar to how this is done for mqt-core. Furthermore, the condition on the Python version is dropped as it was obsolete. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
b6f0c8b
to
79f0e99
Compare
This is the first release of QCEC that also uses the MQT Core Python package. Both, mqt-qmap and mqt-qcec, need to be compiled using the same mqt-core library to avoid ABI incompatibilities. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
these lines are not feasible to test in CI for us at the moment Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
extensive-cpp-ci
Adding this label indicates that extensive C++ CI runs should be started for this PR.
extensive-python-ci
Adding this label indicates that extensive Python CI runs should be started for this PR.
major
Changes leading to a major version increase
packaging
Anything related to Python packaging
python
Anything related to Python code
usability
Anything related to usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the project to use the newly developed
mqt-core
Python package.Any Python package build will only require the
mqt-core
package as a build and runtime dependency and won't have to rely on fetched version of mqt-core any more.Any regular C++ build will still use the
FetchContent
CMake module.The change brings a range of advantages:
load
function ofmqt-core
that allows to load any supported circuit format as input and has better handling for QiskitQuantumCircuit
objects.Checklist: