Ensure delete_expired uses writable database.
#358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Jan 17, 2023
auvipy
requested changes
Nov 8, 2023
auvipy
requested changes
Nov 8, 2023
| def delete_expired(self, expires): | ||
| """Delete all expired results.""" | ||
| with transaction.atomic(using=self.db): | ||
| with transaction.atomic(using=self.database_for_write()): |
There was a problem hiding this comment.
also resolve the merge conflict please?
|
@jacklinke any joy on this one? I'm running into the same issue that you are |
|
Just as a heads-up, #427 also needs a testcase with a read-only connection (See my comment for a suggested approach: #427 (comment)) |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a database routing issue by ensuring the delete_expired method uses the writable database instead of the default read database. This prevents potential failures when using read/write database splitting configurations.
- Extracted database selection logic into a reusable
database_for_write()method - Updated
delete_expiredto use the writable database for atomic transactions - Refactored
connection_for_write()to use the new helper method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
delete_expiredmethod of ResultManager to use writable database.Resolves #357