ci(mergify): upgrade configuration to current format #419
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
rootulp and
ninabarbakadze
and removed request for
a team
.mergify.yml
Outdated
| merge_conditions: | ||
| - "#approved-reviews-by>1" | ||
| merge_method: squash | ||
| commit_message_template: | | ||
| {{ title }} (#{{ number }}) | ||
| {{ body }} |
There was a problem hiding this comment.
this looks suspect because this was moved from under the automerge thing to the queue rules.
Since GitHub now has automerge, we don't use automerge from mergify so I'm inclined to delete that setting entirely.
mergify
bot
force-pushed
the
mergify/configuration-deprecated-update
branch
from
12fa277 to
2eead34
Compare
|
Ugh mergify overwrote my commit. Closing this b/c I don't think we need it. |
mergify
bot
force-pushed
the
mergify/configuration-deprecated-update
branch
from
2eead34 to
40ab4c3
Compare
mergify
bot
force-pushed
the
mergify/configuration-deprecated-update
branch
from
40ab4c3 to
b37c7fb
Compare
|
@rootulp is this still needed? |
|
Yea let's try merging it. We don't use mergify for auto-merge so we don't need some of the config modified in this PR but if it works, we can keep it. |
|
@rootulp can you update this branch to contain the latest commits and rerun CI? 3 are failing |
|
Looks like it already has the latest commits. CI is probably failing on |
|
test-race is failing but I don't think it's using the versions specified in this PR. IMO we should merge this as-is and see if CI passes on |
|
CI passed after merge with the exception of one CI check for pushing a Docker image. |
No more deprecated fields are being used in your Mergify configuration, this pull request will be closed.