simplify monitor address setting #7479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
public_network
branch
from
c15d5ea to
4bd5412
Compare
clwluvw
reviewed
Feb 16, 2024
guits
force-pushed
the
public_network
branch
from
4bd5412 to
00e2182
Compare
clwluvw
reviewed
Feb 16, 2024
clwluvw
reviewed
Feb 16, 2024
clwluvw
reviewed
Mar 6, 2024
guits
force-pushed
the
public_network
branch
2 times, most recently
from
68f8d0c to
9247b1c
Compare
guits
changed the title
guits
changed the title
|
jenkins test centos-non_container-all_daemons |
|
jenkins test centos-container-all_daemons |
|
jenkins test centos-non_container-lvm_osds |
|
jenkins test centos-non_container-lvm_batch |
|
jenkins test centos-container-lvm_osds |
|
jenkins test centos-container-lvm_batch |
|
jenkins test centos-non_container-switch_to_containers |
this drops the following parameters: - monitor_address_block - monitor_interface - monitor_address The monitor address will be automatically set from `public_network` parameter. Signed-off-by: Guillaume Abrioux <[email protected]>
2b72ea9 and c8eeae2 have missed the resync. This addresses that. Signed-off-by: Guillaume Abrioux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this drops the following parameters:
The monitor address will be automatically set from
public_networkparameter.