Adopt with grafana_network not grafana_server_addr #7654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The networks list in a spec is usually a list of ranges, not a single IP. The grafana_server_addr is a fact created from the grafana_network range so it is a more appropriate parameter to pass to the spec. Follow up to 770a527 Signed-off-by: John Fulton <[email protected]>
fultonj
force-pushed
the
grafana_network
branch
from
fc71b24 to
1e74cc6
Compare
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The networks list in a spec is usually a range not a single IP. grafana_server_addr is a fact created from grafana_network so it is a more appropriate parameter to pass.
Follow up to 770a527