Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver APIs and controller definition #14

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

nb-ohad
Copy link
Collaborator

@nb-ohad nb-ohad commented Jun 9, 2024

First pass on driver APIs,

The PR does not include the following todos:

  • A decision around the generalization of the DeployCsiAddons field to other potential external sidecars
  • A list of Status.Reason code/enum values
  • CRD field validation rules

These will be resolved in one or more future PRs

@nb-ohad nb-ohad requested a review from Madhu-1 June 9, 2024 20:38
@nb-ohad nb-ohad force-pushed the driver-api branch 2 times, most recently from 6499a9a to 6f96353 Compare June 13, 2024 10:35
@nb-ohad nb-ohad force-pushed the driver-api branch 2 times, most recently from b0bb3fa to aa67158 Compare June 21, 2024 14:23
@nb-ohad nb-ohad marked this pull request as ready for review June 21, 2024 14:23
@nb-ohad nb-ohad force-pushed the driver-api branch 5 times, most recently from 7536cd9 to 4396e33 Compare June 23, 2024 20:02
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nb-ohad we need to add service account to the driver spec, except that everything else LGTM

api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
@nb-ohad nb-ohad force-pushed the driver-api branch 2 times, most recently from bd1cf52 to 891d32c Compare June 25, 2024 10:14
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
api/v1alpha1/driver_types.go Outdated Show resolved Hide resolved
First pass on driver APIs

Signed-off-by: nb-ohad <[email protected]>
@Madhu-1 Madhu-1 merged commit c416288 into ceph:main Jun 26, 2024
4 checks passed
iamniting pushed a commit to iamniting/ceph-csi-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants