-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver APIs and controller definition #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6499a9a
to
6f96353
Compare
b0bb3fa
to
aa67158
Compare
7536cd9
to
4396e33
Compare
Madhu-1
requested changes
Jun 24, 2024
Madhu-1
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nb-ohad we need to add service account to the driver spec, except that everything else LGTM
bd1cf52
to
891d32c
Compare
Madhu-1
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits
First pass on driver APIs Signed-off-by: nb-ohad <[email protected]>
Madhu-1
approved these changes
Jun 26, 2024
iamniting
pushed a commit
to iamniting/ceph-csi-operator
that referenced
this pull request
Aug 13, 2024
SYNC DS branch with US
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass on driver APIs,
The PR does not include the following todos:
DeployCsiAddons
field to other potential external sidecarsStatus.Reason
code/enum valuesThese will be resolved in one or more future PRs