rbd: get volumegroup in secondary cluster #5118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iPraveenParihar
force-pushed
the
rbd/get-volumegroup-in-secondary-cluster
branch
2 times, most recently
from
a045d55 to
13817b7
Compare
|
Tried relocation of VolumeGroupReplication resources -
|
Rakshith-R
reviewed
Feb 4, 2025
internal/rbd/group/util.go
Outdated
| } | ||
|
|
||
| vg, err := generateVolumeGroup(id, csiDriver, creds, csiID) | ||
| if err != nil && !errors.Is(err, util.ErrPoolNotFound) { |
There was a problem hiding this comment.
you need to make use of the following function instead of singular pool not found check ?
ceph-csi/internal/rbd/rbd_util.go
Line 1308 in c45bc7d
There was a problem hiding this comment.
Yea, we could use this function. But this would result in import cycle issue.
I have tried to refactor and move this helper function to internal/util.
iPraveenParihar
force-pushed
the
rbd/get-volumegroup-in-secondary-cluster
branch
3 times, most recently
from
b5125d5 to
79a1734
Compare
Signed-off-by: Praveen M <[email protected]>
…al/util Signed-off-by: Praveen M <[email protected]>
Currently, `GetVolumeGroup()` fetches the RBD group from the pool using the clusterID & poolID encoded in the VolumeGroupHandle. However, this approach may fail in a secondary mirrored cluster, where the clusterID & poolID could differ. This commit ensures that `GetVolumeGroup` leverages the clusterIDMapping and RBDPoolIDMapping to locate the RBD group in the appropriate pool if it is not found in the pool corresponding to the poolID encoded in the VolumeGroupHandle. Signed-off-by: Praveen M <[email protected]>
iPraveenParihar
force-pushed
the
rbd/get-volumegroup-in-secondary-cluster
branch
from
79a1734 to
a69748b
Compare
nixpanic
requested changes
Feb 6, 2025
| } | ||
| } | ||
|
|
||
| cvg.csiDriver = vg.csiDriver |
There was a problem hiding this comment.
This is really ugly and rather inefficient. It is also very easy to forget copying an attribute of the struct that was set in an other function.
Can't generateVolumeGroup() and generateVolumeGroupFromMapping() not be a function of the commonVolumeGroup type so that they update their own instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Currently,
GetVolumeGroup()fetches the RBD group from the pool using the clusterID & poolID encoded in the VolumeGroupHandle. However, this approach may fail in a secondary mirrored cluster, where the clusterID & poolID could differ.This commit ensures that
GetVolumeGroupleverages the clusterIDMapping and RBDPoolIDMapping to locate the RBD group in the appropriate pool if it is not found in the pool corresponding to the poolID encoded in the VolumeGroupHandle.Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)