Proper support for caching helm chart from Artifactory. #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
the
component/deployment
Lirt
force-pushed
the
compatibility/helm-artifactory
branch
from
919b8c1 to
f7374e2
Compare
nixpanic
added
the
ci/skip/multi-arch-build
|
Hi @Lirt , thanks for the PR! This looks like a reasonable change to me, and you explained the details well. There are two problems that the commit checker bot complains about: ✖ header must not be longer than 72 characters, current length is 73 [header-max-length] Can you amend your commit message and force-push the branch again? |
Lirt
force-pushed
the
compatibility/helm-artifactory
branch
from
f7374e2 to
0944d65
Compare
Currently helm index configures URLs to charts with relative path (see https://ceph.github.io/csi-charts/index.yaml). Artifactory contains support for virtual repositories. Virtual repositories are able to cache remote repositories and provide offline access to those repositories. In order for this to work correctly, charts must specify absolute base URL to artifacts. This commit adds this base URL using argument for helm index command. URL with previous approach: ```yaml urls: - cephfs/ceph-csi-cephfs-3.13.0.tgz ``` URL with current approach (my personal "lirt" repo was used to test this, the MR specifies correct "ceph" path) ```yaml urls: - https://lirt.github.io/csi-charts/cephfs/ceph-csi-cephfs-3.13.0.tgz ``` Signed-off-by: Ondrej Vasko <[email protected]>
Lirt
force-pushed
the
compatibility/helm-artifactory
branch
from
0944d65 to
971a2cd
Compare
|
Hi @nixpanic, apologize for rookie mistakes :-). Updated message+body and gpg verification of commit. |
No problem, thanks for the update! Some of the automated checks are rather strict, these things happen to all of us 😄 |
nixpanic
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently helm index of ceph helm repository configures URLs to charts with relative path (see https://ceph.github.io/csi-charts/index.yaml).
Artifactory contains support for virtual repositories. Virtual repositories are able to cache remote repositories and provide offline access to those repositories.
In order for this to work correctly, charts must specify absolute base URL to artifacts.
This commit adds this base URL using argument for helm index command.
URL with previous approach:
URL with current approach (my personal "lirt" repo was used to test this, the MR specifies correct "ceph" path)
Is there anything that requires special attention
This change is backwards compatible.
You can try following commands that suggest the path is the same as previously and work with original repo and updated repo as well. Of course the MR specifies
ceph.prefix.Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.