admin/smb: add an example of using generic resources#1232
Merged
mergify[bot] merged 1 commit intoceph:masterfrom Feb 24, 2026
Merged
admin/smb: add an example of using generic resources#1232mergify[bot] merged 1 commit intoceph:masterfrom
mergify[bot] merged 1 commit intoceph:masterfrom
Conversation
anoopcs9
reviewed
Feb 23, 2026
Collaborator
anoopcs9
left a comment
There was a problem hiding this comment.
I'm not sure if this is the right place. What if we extend hints.md or even create a separate one for this particular use case with relevant code snippets?
Collaborator
Author
|
I want this to show up in the API docs once we stablise the API. This is the way to do whole file examples as far as I know. |
Collaborator
Author
anoopcs9
reviewed
Feb 23, 2026
Collaborator
anoopcs9
left a comment
There was a problem hiding this comment.
Thanks, now it makes sense.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
ef989ab to
050155d
Compare
Merge Queue StatusRule:
This pull request spent 23 seconds in the queue, with no time running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a godoc example file that tries to explain how to use Generic Resources.
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.