Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cms-201Y-collision-datasets-hi: add hlt trigger path for hlt snippets #180

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

katilp
Copy link
Member

@katilp katilp commented Aug 2, 2023

(closes #178 )

@tiborsimko if needed I can easily modify the script to produce exactly the same format as in previous years, let me know.

Compared to the previous text, adds the word "validated" in front of "run"

@katilp katilp requested a review from tiborsimko August 2, 2023 20:00
@tiborsimko tiborsimko force-pushed the cms-hi-hlt-trigger-paths branch from 320a6db to f4268b4 Compare August 16, 2023 13:28
@@ -0,0 +1,702 @@
High-Level Trigger path information HLT_Activity_Ecal_SC7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format is OK, although for better separation and readability we may want to add empty line before "High-Level Trigger path information.".

BTW I have split 2013 directory into cms-2013-collision-datasets-hi-ppref and cms-2013-collision-datasets-hi separate directories in my local WIP branch, as we had discussed about it live.

How would it affect the HLT trigger listing? Could we easily split them, or we'll have them in one place and use symlinks?

Copy link
Member Author

@katilp katilp Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have these lists in one place (with symlinks) as they come from the same source which does not distinguish the collision type.

Fine for adding the line. Can you easily do it when you're on it? I can do it as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll merge "as is" and then add separating lines whilst creating HTL trigger path records.

@tiborsimko tiborsimko merged commit f4268b4 into master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS - trigger HLT snippets for 2013 and 2015 pp ref
2 participants