-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #231 #232
Fixes #231 #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ari-mu-l @jmhogan Sorry for the long delay... I'm testing this now with the values from MC2015/HiggsPhysics (still missing in the 2015 MC records). When I run the script, I observe 94 cases where the addition would be as follows:
+ "cross_section": {
+ "filter_efficiency": "1.000e+00",
+ "total_value": "0.000e+00",
+ "total_value_uncertainty": "0.000e+00"
+ },
Why would this happen? Is it OK that we would display such values, or should the script filter out those that just have 0.000 as x-sec?
Hello @katilp, are the cross sections 0 in the original log files? The utility script itself doesn't check for 0 cross sections. It just extracts whatever value outputted by the GenXSecAnalyzer. |
@Ari-mu-l, yes, there are. Most of them are like this:
i.e. with the non-zero cross-section going to zero They are e.g.:
and three So guess we just filter them out. |
@Ari-mu-l : @d0leh and @danaalsharif can look how to exclude the zero values in the script. |
@katilp Got it. Thank you! Please let me know whenever there's something that I can help with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is goodo to go, thanks!
Update helper script `update_fixtures_cross_sections.py` to handle the new xsec formats (used in all xsec json files except for MC2015/StandardModelPhysics).
Update helper script `update_fixtures_cross_sections.py` for 2015 Higgs and beyond, so that the "-9"s do not get added to the record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, squashed a few intermediate commits, enriched the author list, merging...
Only add cross_section field when total_value is not zero. Fix code formatting to conform to `black` coding style. Enrich authors list and fix empty links there. Co-authored-by: Tibor Šimko <[email protected]>
Fixes #231
Now works for both 2015 SM and 2015 Higgs.
Also works for updating 2016 SM and Higgs, but user needs to change the name of the json file records in the script from "...2015..." to "...2016..." (L265) before execution.