Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #231 #232

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Fixes #231 #232

merged 3 commits into from
Sep 9, 2024

Conversation

Ari-mu-l
Copy link
Contributor

@Ari-mu-l Ari-mu-l commented May 21, 2024

Fixes #231

Now works for both 2015 SM and 2015 Higgs.
Also works for updating 2016 SM and Higgs, but user needs to change the name of the json file records in the script from "...2015..." to "...2016..." (L265) before execution.

Copy link
Member

@katilp katilp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ari-mu-l @jmhogan Sorry for the long delay... I'm testing this now with the values from MC2015/HiggsPhysics (still missing in the 2015 MC records). When I run the script, I observe 94 cases where the addition would be as follows:

+    "cross_section": {
+      "filter_efficiency": "1.000e+00",
+      "total_value": "0.000e+00",
+      "total_value_uncertainty": "0.000e+00"
+    },

Why would this happen? Is it OK that we would display such values, or should the script filter out those that just have 0.000 as x-sec?

@Ari-mu-l
Copy link
Contributor Author

Hello @katilp, are the cross sections 0 in the original log files? The utility script itself doesn't check for 0 cross sections. It just extracts whatever value outputted by the GenXSecAnalyzer.

@katilp
Copy link
Member

katilp commented Jun 24, 2024

@Ari-mu-l, yes, there are. Most of them are like this:

  {
    "equivalent_lumi_uncertainty": "-9",
    "total_value_uncertainty": "0.000e+00",
    "filter_efficiency_evt_uncertainty": "0.000e+00",
    "xsec_before_matching": "1.835e+01",
    "xsec_before_filter": "-9",
    "HepMC_filter_efficiency": "-9",
    "xsec_after_matching": "-1.835e+01",
    "filter_efficiency": "1.000e+00",
    "xsec_before_matching_uncertainty": "1.579e-02",
    "xsec_after_matching_uncertainty": "0.000e+00",
    "equivalent_lumi": "-9",
    "HepMC_filter_efficiency_uncertainty": "-9",
    "total_value": "0.000e+00",
    "HepMC_filter_efficiency_evt_uncertainty": "-9",
    "filter_efficiency_uncertainty": "0.000e+00",
    "xsec_before_filter_uncertainty": "-9",
    "neg_weight_fraction_uncertainty": "-9",
    "filter_efficiency_evt": "1.000e+00",
    "matching_efficiency": "-9",
    "neg_weight_fraction": "-9",
    "Dataset": "/GluGlu_HToMuMu_M150_13TeV_powheg_pythia8/RunIIFall15MiniAODv2-PU25nsData2015v1_76X_mcRun2_asymptotic_v12-v1/MINIAODSIM",
    "HepMC_filter_efficiency_evt": "-9",
    "matching_efficiency_uncertainty": "-9"
  } 

i.e. with the non-zero cross-section going to zero after_matching_uncertainty.

They are e.g.:

  • 24 are some ttH, e.g /ttH_M70_13TeV_powheg_pythia8/RunIIFall15MiniAODv2-PU25nsData2015v1_76X_mcRun2_asymptotic_v12-v1/MINIAODSIM
  • 52 of some VBF e.g. VBF_LFV_HToMuTau_M200_13TeV_powheg_pythia8 (with or without LFV)
  • 16 of some GluGlu with or without LFV

and three /bbHToWWTo2L2Nu with all values 0.

So guess we just filter them out.

@katilp
Copy link
Member

katilp commented Jun 25, 2024

@Ari-mu-l : @d0leh and @danaalsharif can look how to exclude the zero values in the script.

@Ari-mu-l
Copy link
Contributor Author

@katilp Got it. Thank you! Please let me know whenever there's something that I can help with.

Copy link
Member

@katilp katilp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is goodo to go, thanks!

Update helper script `update_fixtures_cross_sections.py` to handle the
new xsec formats (used in all xsec json files except for
MC2015/StandardModelPhysics).
Update helper script `update_fixtures_cross_sections.py` for 2015 Higgs
and beyond, so that the "-9"s do not get added to the record.
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, squashed a few intermediate commits, enriched the author list, merging...

Only add cross_section field when total_value is not zero.

Fix code formatting to conform to `black` coding style.

Enrich authors list and fix empty links there.

Co-authored-by: Tibor Šimko <[email protected]>
@tiborsimko tiborsimko merged commit a3100fa into cernopendata:master Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS - debug cross-section utility script for case HiggsPhysics/StandardModelPhysics
4 participants