Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: link scheduling #75

Merged
merged 17 commits into from
Feb 27, 2025
Merged

feat: link scheduling #75

merged 17 commits into from
Feb 27, 2025

Conversation

AfonsoMartins26
Copy link
Contributor

No description provided.

@AfonsoMartins26 AfonsoMartins26 linked an issue Sep 18, 2024 that may be closed by this pull request
Link scheduling #73
Closed
@AfonsoMartins26 AfonsoMartins26 changed the title Feat: update list_unarchived_links_by_index Link scheduling Sep 18, 2024
@AfonsoMartins26 AfonsoMartins26 marked this pull request as draft September 18, 2024 20:59
@AfonsoMartins26 AfonsoMartins26 changed the title Link scheduling feat: link scheduling Sep 18, 2024
@AfonsoMartins26 AfonsoMartins26 marked this pull request as ready for review September 19, 2024 10:28
MarioRodrigues10
MarioRodrigues10 requested changes Sep 20, 2024
View reviewed changes
@AfonsoMartins26 AfonsoMartins26 self-assigned this Sep 22, 2024
joaodiaslobo
joaodiaslobo requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 🤩
Can you add a timer to links that have been scheduled and maybe reduce their opacity while not published?
Something like this:
image

@AfonsoMartins26 AfonsoMartins26 requested review from joaodiaslobo and removed request for JulioJPinto September 23, 2024 17:49
@AfonsoMartins26
Copy link
Contributor Author

AfonsoMartins26 commented Sep 27, 2024 •
edited
Loading

Works great! 🤩 Can you add a timer to links that have been scheduled and maybe reduce their opacity while not published? Something like this: image

The opacity is working but it doesn't go away when the link gets to the home page.... 😿

joaodiaslobo
joaodiaslobo requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything backend-wise is great! Good job!
Now, to represent a scheduled link on the backoffice table, we should probably use JavaScript to make it more interactive and up to date. Learn more about Phoenix hooks here

MarioRodrigues10
MarioRodrigues10 requested changes Jan 10, 2025
View reviewed changes
MarioRodrigues10
MarioRodrigues10 previously requested changes Jan 12, 2025
View reviewed changes
joaodiaslobo
joaodiaslobo approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!! 🔥🔥🔥

@joaodiaslobo joaodiaslobo merged commit a5df8d4 into main Feb 27, 2025
2 checks passed
@joaodiaslobo joaodiaslobo deleted the am/linkscheduling branch February 27, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonmestevao nelsonmestevao nelsonmestevao left review comments

@joaodiaslobo joaodiaslobo joaodiaslobo approved these changes

@nunom27 nunom27 Awaiting requested review from nunom27

@FilipeR13 FilipeR13 Awaiting requested review from FilipeR13

@MarioRodrigues10 MarioRodrigues10 Awaiting requested review from MarioRodrigues10

Assignees

@AfonsoMartins26 AfonsoMartins26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link scheduling
4 participants
@AfonsoMartins26 @nelsonmestevao @joaodiaslobo @MarioRodrigues10