Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main -> CO5/Develop #126

Merged
merged 26 commits into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
fe7a073
#113 - Fix UTF-8 - BOM encoding issue when downloading one of "my pro…
scoxen1 Jul 16, 2024
0f3ce33
Update backend-publish-stage-azure.yml (Adding branch PLY/Develop)
PaulLinYao Jul 27, 2024
1089799
Update frontend-publish-stage-azure.yml (Add branch PLY/Develop)
PaulLinYao Jul 27, 2024
8541559
Update sonar-cloud-scan-stage.yml (Add branch PLY/Develop)
PaulLinYao Jul 27, 2024
a5ce775
Update tests.yml (add branch PLY/Develop)
PaulLinYao Jul 27, 2024
cc7285f
Delete .github/workflows/tests-in-browser.yml (placeholder YML file -…
PaulLinYao Jul 27, 2024
9888173
Link to submodule CESMII-Common
PaulLinYao Jul 27, 2024
e20f71f
Cloud Test -- add in missing SearchAsync function in mock tests neede…
PaulLinYao Jul 29, 2024
6ad7bf5
Update sonar-cloud-scan.yml -- Java SDK action. Upgrade actions/setup…
PaulLinYao Jul 29, 2024
5713a3e
Update sonar-cloud-scan.yml -- Fix java class file version error by u…
PaulLinYao Jul 29, 2024
959119a
Update sonar-cloud-scan.yml -- update out of date actions (to actions…
PaulLinYao Jul 29, 2024
2b23605
Update sonar-cloud-scan-stage.yml -- update to match changes already …
PaulLinYao Jul 29, 2024
3af3cce
Update backend-publish-stage-azure.yml -- update to actions/checkout@…
PaulLinYao Jul 29, 2024
16c7edd
Update frontend-publish-stage-azure.yml -- updating to actions/checko…
PaulLinYao Jul 29, 2024
1dd1ce5
Update tests.yml -- update to actions/checkout@v4 and actions/setup-d…
PaulLinYao Jul 29, 2024
ca80275
Update frontend-publish-azure.yml -- Update to actions/checkout@v4 an…
PaulLinYao Jul 29, 2024
9270306
Update backend-publish-azure.yml -- update to actions/checkout@v4 and…
PaulLinYao Jul 29, 2024
9094b78
Sssu - just added de-bouncing to CESMII-Common. Link now to main module.
PaulLinYao Jul 30, 2024
f0373af
Sssu - Removing dictionary. Link to Submodule CESMII-Common
PaulLinYao Jul 30, 2024
372abca
Sssu - Link to CESMII-Common to return BadRequest for extra user clicks
PaulLinYao Jul 30, 2024
9e4f252
Sssu - Adding in dictionary - linking to CESMII-Common
PaulLinYao Jul 30, 2024
b600e87
Merge pull request #114 from cesmii/feature/113-UTF8-Encoding
scoxen1 Jul 30, 2024
1335503
Merge pull request #121 from cesmii/CO5/Develop
scoxen1 Aug 19, 2024
5b4e032
Make equivalent to Main - resolve merge conflicts
scoxen1 Aug 20, 2024
1df02e6
Merge pull request #125 from cesmii/CO5/Develop
scoxen1 Aug 20, 2024
269c267
Update README.md
scoxen1 Sep 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/backend-publish-azure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ env:

jobs:
build:
name: Build and Deploy .NET5 Web API
name: Build and Deploy .NET6 Web API
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Set up dotnet Core ${{ env.NETCORE_VERSION }}
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: ${{ env.NETCORE_VERSION }}
- name: Restore dependencies (${{env.SOLUTION_FILE}})
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/backend-publish-stage-azure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ on:
branches:
- develop
- CO5/Develop
- PLY/Develop

env:
# set this to your application's name
Expand All @@ -47,11 +48,11 @@ jobs:
name: Build and Deploy .NET6 Web API
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Set up dotnet Core ${{ env.NETCORE_VERSION }}
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: ${{ env.NETCORE_VERSION }}
- name: Restore dependencies (${{env.SOLUTION_FILE}})
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/frontend-publish-azure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
name: 'Job: Build and Deploy React frontend'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
- name: 'Build React Code - npm install, build'
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/frontend-publish-stage-azure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ on:
branches:
- develop
- CO5/Develop
- PLY/Develop

env:
# set this to your application's name
Expand All @@ -40,9 +41,9 @@ jobs:
name: 'Job: Build and Deploy React frontend'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
- name: 'Build React Code - npm install, build'
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/sonar-cloud-scan-stage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
branches:
- develop
- CO5/Develop
- PLY/Develop

env:
# set this to the organization name, project key in Sonar
Expand Down Expand Up @@ -45,20 +46,20 @@ jobs:
steps:
#Set up Java which is needed for SonarScan post processing step
- name: Setup Java JDK
uses: actions/setup-java@v3.4.0
uses: actions/setup-java@v4.2.1
with:
distribution: 'microsoft' # See 'Supported distributions' for available options
java-version: '11'
java-version: '17'

- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
# Shallow clones should be disabled for a better relevancy of analysis
fetch-depth: 0
submodules: true

# Speed-up analysis by caching the scanner workspace
- name: SonarScan - Cache SonarCloud workspace
uses: actions/cache@v1
uses: actions/cache@v4
with:
path: ~\.sonar\cache
key: ${{ runner.os }}-sonar-cache
Expand All @@ -67,7 +68,7 @@ jobs:
# Speed-up analysis by caching the scanner installation
- name: SonarScan - Cache SonarCloud scanner
id: cache-sonar-scanner
uses: actions/cache@v1
uses: actions/cache@v4
with:
path: ${{env.SONAR_TOOL_PATH}}
key: ${{ runner.os }}-sonar-scanner
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/sonar-cloud-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,20 @@ jobs:
steps:
#Set up Java which is needed for SonarScan post processing step
- name: Setup Java JDK
uses: actions/setup-java@v3.4.0
uses: actions/setup-java@v4.2.1
with:
distribution: 'microsoft' # See 'Supported distributions' for available options
java-version: '11'
java-version: '17'

- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
# # Shallow clones should be disabled for a better relevancy of analysis
# fetch-depth: 0
submodules: true

# Speed-up analysis by caching the scanner workspace
- name: SonarScan - Cache SonarCloud workspace
uses: actions/cache@v1
uses: actions/cache@v4
with:
path: ~\.sonar\cache
key: ${{ runner.os }}-sonar-cache
Expand All @@ -66,7 +66,7 @@ jobs:
# Speed-up analysis by caching the scanner installation
- name: SonarScan - Cache SonarCloud scanner
id: cache-sonar-scanner
uses: actions/cache@v1
uses: actions/cache@v4
with:
path: ${{env.SONAR_TOOL_PATH}}
key: ${{ runner.os }}-sonar-scanner
Expand All @@ -85,4 +85,4 @@ jobs:
- name: Build (${{env.SOLUTION_FILE}})
run: dotnet build ${{env.SOLUTION_DIRECTORY}}/${{env.SOLUTION_FILE}} --configuration ${{ env.BUILD_CONFIGURATION }} --no-restore
- name: SonarScan - End (${{env.SONAR_PROJECT_KEY}})
run: ${{env.SONAR_TOOL_PATH}}\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_ACCESS_TOKEN }}"
run: ${{env.SONAR_TOOL_PATH}}\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_ACCESS_TOKEN }}"
17 changes: 0 additions & 17 deletions .github/workflows/tests-in-browser.yml

This file was deleted.

6 changes: 4 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ on:
branches:
- develop
- CO5/Develop
- PLY/Develop
- main
pull_request:
branches:
- develop
- CO5/Develop
- PLY/Develop
- main

env:
Expand All @@ -34,11 +36,11 @@ jobs:
name: Build and Test .NET6 Web API
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Set up dotnet Core ${{ env.NETCORE_VERSION }}
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: ${{ env.NETCORE_VERSION }}

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<h2>Prerequisites</h2>
<ul>
<li>
Install node.js (version > 10.16) - https://nodejs.org/en/
Install node.js (version > 18.17) - https://nodejs.org/en/
</li>
<li>
Install npm (version > 5.6) - https://www.npmjs.com/ (note I just upgraded to 7.17 => npm install -g npm)
Install npm (version > 8.5.4) - https://www.npmjs.com/ (npm install -g npm)
</li>
<li>
React - https://reactjs.org/ - First time React users, install React using create-react-app from a node.js command prompt, a tool that installs all of the dependencies to build and run a full React.js application.
Expand Down
2 changes: 1 addition & 1 deletion api/CESMII.ProfileDesigner.OpcUa/OpcUaImporter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ public async System.Threading.Tasks.Task<Dictionary<string, ProfileTypeDefinitio
string exportedNodeSetXml;
using (MemoryStream ms = new())
{
using (StreamWriter writer = new(ms, Encoding.UTF8))
using (StreamWriter writer = new(ms, new UTF8Encoding(false)))
{
try
{
Expand Down
Loading
Loading