Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWDP UI to color code based on org #42

Merged
merged 14 commits into from
Jan 21, 2025
Merged

Update OWDP UI to color code based on org #42

merged 14 commits into from
Jan 21, 2025

Conversation

webb-ben
Copy link
Member

@webb-ben webb-ben commented Jan 18, 2025 •
edited
Loading

Note: Requires clearing existing STA database to implement

@webb-ben
Use common field name for organization
a4c07ab 
- Featureid should be the same as datastream so also cast it to a string
@webb-ben
Use OWDP specific UI
5cc5cae
@webb-ben webb-ben requested a review from C-Loftus January 18, 2025 18:43
C-Loftus
C-Loftus reviewed Jan 18, 2025
View reviewed changes
Copy link
Member

@C-Loftus C-Loftus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all good, just wanted to get clarification on why we are changing 2 things for my own understanding

docker/frost/Dockerfile Show resolved Hide resolved
userCode/odwr/sta_generation.py Show resolved Hide resolved
@C-Loftus C-Loftus self-requested a review January 18, 2025 18:54
@webb-ben webb-ben changed the title Update OWDP UI to color code base on org Update OWDP UI to color code based on org Jan 20, 2025
@webb-ben webb-ben requested a review from C-Loftus January 20, 2025 16:15
@webb-ben
Copy link
Member Author

@C-Loftus re-requesting review with subsequent changes:

  • userCode/odwr/helper_classes.py and tests/odwr/lib.py moved to parent dir
  • Add nginx retry strategy to resolve unquoted Sensorthings items
  • Request 4326 odwr geometry

C-Loftus
C-Loftus approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@C-Loftus C-Loftus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@webb-ben webb-ben merged commit b64809f into master Jan 21, 2025
3 checks passed
@webb-ben webb-ben deleted the common-features branch January 21, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C-Loftus C-Loftus C-Loftus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webb-ben @C-Loftus