Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't block fetches #5632

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: don't block fetches #5632

merged 1 commit into from
Feb 13, 2025

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Feb 13, 2025

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Picks: #5631 from 1.8 to main.

@kylezs kylezs requested a review from dandanlen as a code owner February 13, 2025 08:02
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 95.87629% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
state-chain/pallets/cf-ingress-egress/src/tests.rs 93% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dandanlen dandanlen added this pull request to the merge queue Feb 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@kylezs kylezs added this pull request to the merge queue Feb 13, 2025
@kylezs
Copy link
Contributor Author

kylezs commented Feb 13, 2025

I'm looking to fix that flakiness issue in #5612

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@dandanlen dandanlen added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@kylezs kylezs added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit f233e94 Feb 13, 2025
48 checks passed
@kylezs kylezs deleted the pick/fix-dont-block-fetches branch February 13, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants