feat(github): Use regular CLI steps in scorecards workflow #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - name: Install Chainloop | ||
| run: | | ||
| curl -sfL https://raw.githubusercontent.com/chainloop-dev/chainloop/01ad13af08950b7bfbc83569bea207aeb4e1a285/docs/static/install.sh | bash -s |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
migmartri
approved these changes
Jan 10, 2025
.github/workflows/scorecards.yml
Outdated
|
|
||
| steps: | ||
| - name: Install Cosign |
There was a problem hiding this comment.
do we need cosign anymore? This is to verify signature of the installed chainloop correct?
.github/workflows/scorecards.yml
Outdated
| - name: Finish and Record Attestation | ||
| if: ${{ success() }} | ||
| run: | | ||
| chainloop attestation status --full |
There was a problem hiding this comment.
no need to show status anymore, push will do it for you
Signed-off-by: Javier Rodriguez <[email protected]>
javirln
added a commit
that referenced
this pull request
Jan 10, 2025
…1723)' Signed-off-by: Javier Rodriguez <[email protected]>
javirln
added a commit
that referenced
this pull request
Jan 16, 2025
…1723)" (#1727) Signed-off-by: Javier Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes all code related to chainloop labs and use plain CLI commands to run the scorecards workflow.
A successful workflow can be found here: https://github.com/chainloop-dev/chainloop/actions/runs/12709541017/job/35428753447?pr=1723
Close #1721