test: test for the agent added #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
requested changes
Nov 26, 2024
Co-authored-by: Aman Sharma <[email protected]>
Co-authored-by: Aman Sharma <[email protected]>
algomaster99
requested changes
Nov 28, 2024
| } | ||
|
|
||
| private boolean isAdditionalMethodPresent(ClassReader classReader) { | ||
| final boolean[] methodPresent = {false}; |
There was a problem hiding this comment.
why is this a boolean[]? I think it can be be simply boolean.
There was a problem hiding this comment.
I used the array because it is in an inner class and it requires a final variable. But If the variable is final I cannot change its value from false to true. Using the array I can declare it final and also modify it. But if you think it is better not to use an array, I can declare a boolean as a class-level field.
There was a problem hiding this comment.
I can declare a boolean as a class-level field.
That would be a good coding practice. To declare it as a private field.
|
|
||
| private boolean isAdditionalMethodInvoked(ClassReader classReader) { | ||
| final boolean[] methodInvoked = {false}; | ||
| classReader.accept(new ClassVisitor(Opcodes.ASM9) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test include: