Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dirty-waters to CI #1083

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

randomicecube
Copy link

cc @monperrus @Stamp9

Relates to INRIA/spoon#5216, chains-project/dirty-waters#37, chains-project/dirty-waters#58

Key notes:

  • x_to_fail parameter: the percentage of a single non-high severity issue present among the dependencies for the CI to break. It defaults to 5%, so what should it be here?
  • comment_on_commit: whether the reports are allowed to be pasted as comments in the commits, in the case of high-severity issues breaking CI. Defaults to false, what do we want here?
  • allow_pr_comments: whether the reports are allowed to be pasted as comments in pull requests. Defaults to true, what do we want here?
  • By default, only static analysis happens. Do we want differential to be performed in certain scenarios too? If so, which ones?
  • Gradual reporting is enabled by default -- only one of the reported smells has its table displayed per time, with the higher severity issues showing up first.
  • Which maven build commands should be ran before running the dirty-waters action (if any)?

For more information on the action, see the wiki.

@monperrus
Copy link
Contributor

monperrus commented Feb 19, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants