Use ECDSA/k256 for sov signatures #1798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ercecan
changed the title
kpp
reviewed
Feb 4, 2025
kpp
reviewed
Feb 4, 2025
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs
Outdated
Show resolved
Hide resolved
kpp
reviewed
Feb 7, 2025
| @@ -1,5 +1,6 @@ | |||
| [public_keys] | |||
| sequencer_public_key = "4682a70af1d3fae53a5a26b682e2e75f7a1de21ad5fc8d61794ca889880d39d1" | |||
| # TODO: Add sequencer_k256_public_key | |||
kpp
reviewed
Feb 7, 2025
eyusufatik
requested changes
Feb 11, 2025
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/soft_confirmation.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/lib.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/zk/batch_proof/output/v3.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/module-implementations/sov-accounts/src/hooks.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+175
to
+190
| SignedSoftConfirmation::new( | ||
| signed_soft_confirmation.l2_height(), | ||
| signed_soft_confirmation.hash(), | ||
| signed_soft_confirmation.prev_hash(), | ||
| signed_soft_confirmation.da_slot_height(), | ||
| signed_soft_confirmation.da_slot_hash(), | ||
| signed_soft_confirmation.da_slot_txs_commitment(), | ||
| signed_soft_confirmation.l1_fee_rate(), | ||
| signed_soft_confirmation.blobs().to_vec().into(), | ||
| parsed_txs.into(), | ||
| signed_soft_confirmation.deposit_data().to_vec(), | ||
| signed_soft_confirmation.signature().to_vec(), | ||
| signed_soft_confirmation.pub_key().to_vec(), | ||
| signed_soft_confirmation.timestamp(), | ||
| ) | ||
| }; |
There was a problem hiding this comment.
not sure if possible
because I would need to do from SignedSoftConfirmation<PreForkTransaction> for SignedSoftConfirmation
I can not do this outside of the crate, I cannot do this in the crate because I do not have access to those concrete types
so pass I think
kpp
approved these changes
Feb 11, 2025
…y constants in guest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses k256 after fork2 instead of dalek signatures
With this pr we will be getting rid of sha 512 after fork2 and we will be using k256 signatures.
Main reason to do this is ABOUT 10% our cycles are coming form Dalek signatures and sha512, and risc0 has k256 accelerator so our cycles will drop quite a bit.
Linked Issues
Benchmark
Some stats with 3055 txs in around 15 blocks:
Nightly:
this pr:
with 3055 txs in around 15 blocks we can see ~3.5% drop in cycle counts, this drop will be much more in real scenarios when txs are more spread to more blocks, instead 3000 txs being compressed to 15 blocks like in this case.