Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile testing targets improvements #1828

Open
wants to merge 11 commits into
base: nightly
Choose a base branch
from

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Feb 6, 2025

Changes

  • Github CI: Prevent building the binary for tests twice
    • Added a step for invoking make build-test in github checks.yml
  • Github CI: Now invokes make test-ci and make coverage-ci using the prebuilt binary
  • make test and make coverage are for local use where the binary gets built as a dependency to the make target
  • Add two new make targets, to pick and choose which tests to run locally:
    • make -C bin/citrea mock-e2e
    • make -C bin/citrea bitcoin-e2e
  • Reorganize tests into mock-e2e and bitcoin-e2e
    • Add common stuff in bin/citrea/tests/common

@rakanalh rakanalh requested a review from eyusufatik as a code owner February 6, 2025 19:35
@auto-assign auto-assign bot requested a review from jfldde February 6, 2025 19:35
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.6%. Comparing base (1a9c200) to head (9c3b15b).
Report is 4 commits behind head on nightly.

Additional details and impacted files

see 17 files with indirect coverage changes

@jfldde
Copy link
Contributor

jfldde commented Feb 6, 2025

I am not sure about this PR e2e and bitcoin renaming, makes it confusing.
Maybe e2e/bitcoin e2e/mock would better represent it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants