Skip to content

Add compile-time query validation#14

Merged
champ96k merged 1 commit intomasterfrom
Add-compile-time-query-validation
May 27, 2025
Merged

Add compile-time query validation#14
champ96k merged 1 commit intomasterfrom
Add-compile-time-query-validation

Conversation

@champ96k
Copy link
Copy Markdown
Owner

Add compile-time query validation

@github-actions
Copy link
Copy Markdown

⚠️ Gemini Failed, fallback to OpenRouter:

✅ LGTM! No major issues found. Good to go!

The changes added a validation check for the query parameters limit, offset, and their sum to ensure they are non-negative. This check is now performed in both the Query constructor and in the query and watch methods of the QueryEngine. This will help to avoid potential errors in the future.

Additionally, the _validateQuery method has been added in the Query class to encapsulate this validation logic, making the code more modular and easier to maintain. Overall, these changes seem to improve the robustness of the code without introducing any significant issues or performance problems.

@champ96k champ96k merged commit 0ac86e6 into master May 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant