-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add msk probes and actions #148
add msk probes and actions #148
Conversation
860c180
to
0af1f6e
Compare
Signed-off-by: Jorge Tapicha <[email protected]>
Signed-off-by: Jorge Tapicha <[email protected]> Signed-off-by: Jorge Tapicha <[email protected]>
Signed-off-by: Jorge Tapicha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just a couple of minor changes
chaosaws/msk/probes.py
Outdated
try: | ||
return client.describe_cluster(ClusterArn=cluster_arn) | ||
except client.exceptions.NotFoundException as e: | ||
raise FailedActivity("The specified cluster was not found") from e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain the need for the from e
here?
Signed-off-by: Jorge Tapicha <[email protected]>
Signed-off-by: Jorge Tapicha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces new functionalities for the Chaos Toolkit AWS extension to support Amazon MSK (Managed Streaming for Apache Kafka). The added functionalities include:
describe_msk_cluster
: A function to describe MSK clusters.get_bootstrap_servers
: A function to retrieve the bootstrap servers of an MSK cluster.reboot_msk_broker
: A function to reboot a MSK broker.Additionally, unit tests for these functions are included to ensure reliability and correctness.
Example
Checklist