add msk probes and actions#148
Merged
Lawouach merged 5 commits intochaostoolkit-incubator:masterfrom Jun 10, 2024
Merged
Conversation
jitapichab
force-pushed
the
feature/msk
branch
3 times, most recently
from
860c180 to
0af1f6e
Compare
Signed-off-by: Jorge Tapicha <jitapichab@gmail.com>
Signed-off-by: Jorge Tapicha <jitapichab@gmail.com> Signed-off-by: Jorge Tapicha <jitapichab@gmail.com>
Signed-off-by: Jorge Tapicha <jitapichab@gmail.com>
Lawouach
requested changes
May 30, 2024
Contributor
Lawouach
left a comment
Lawouach
left a comment
There was a problem hiding this comment.
LGTM
just a couple of minor changes
chaosaws/msk/probes.py
Outdated
| try: | ||
| return client.describe_cluster(ClusterArn=cluster_arn) | ||
| except client.exceptions.NotFoundException as e: | ||
| raise FailedActivity("The specified cluster was not found") from e |
Contributor
There was a problem hiding this comment.
can you explain the need for the from e here?
Signed-off-by: Jorge Tapicha <jitapichab@gmail.com>
Signed-off-by: Jorge Tapicha <jitapichab@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new functionalities for the Chaos Toolkit AWS extension to support Amazon MSK (Managed Streaming for Apache Kafka). The added functionalities include:
describe_msk_cluster: A function to describe MSK clusters.get_bootstrap_servers: A function to retrieve the bootstrap servers of an MSK cluster.reboot_msk_broker: A function to reboot a MSK broker.Additionally, unit tests for these functions are included to ensure reliability and correctness.
Example
Checklist