Skip to content

[WIP] #139 Redis & EventHub - #143

Open
xpdable wants to merge 2 commits into
chaostoolkit-incubator:masterfrom
xpdable:master
Open

[WIP] #139 Redis & EventHub#143
xpdable wants to merge 2 commits into
chaostoolkit-incubator:masterfrom
xpdable:master

Conversation

@xpdable

@xpdable xpdable commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@Lawouach

Lawouach commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Hello @xpdable

Thanks. It would probably better to not mix a PR for both aspects: adding redis and changing again the client auth.

Also using eval will indeed be a nogo. Better use the importlib mechanism?

@xpdable

xpdable commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

I see no impact if I tell the return type of the init method.

and OK, will think about the init refactory after redis and eventhub PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants