Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unicode characters to writing tests. #64

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Added unicode characters to writing tests. #64

merged 1 commit into from
Sep 12, 2020

Conversation

chapinb
Copy link
Owner

@chapinb chapinb commented Sep 12, 2020

#12

@chapinb chapinb self-assigned this Sep 12, 2020
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 12, 2020

Sourcery Code Quality Report (beta)

❌  Merging this PR will decrease code quality in the affected files by 0.02 out of 10.

Quality metrics Before After Change
Complexity 0.35 0.35 0.00
Method Length 44.82 45.34 0.52 🔴
Quality 8.90 8.88 -0.02 🔴
Other metrics Before After Change
Lines 165 166 1
Changed files Quality Before Quality After Quality Change
libchickadee/test/test_resolver_ipapi.py 8.90 8.88 -0.02 🔴

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
libchickadee/test/test_resolver_ipapi.py IPAPITestCase.test_ipapi_rate_limiting 1 149.72 6.73 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@chapinb chapinb merged commit add3725 into master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant