Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support replying to inline comments #9

Open
charignon opened this issue Mar 4, 2019 · 1 comment
Open

Support replying to inline comments #9

charignon opened this issue Mar 4, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@charignon
Copy link
Owner

It would be nice if github-review could support replies to inline comments posted by others.
@charignon charignon mentioned this issue Mar 4, 2019
Merged
5 tasks
@charignon charignon added the enhancement New feature or request label Mar 9, 2019
charignon added a commit that referenced this issue Mar 10, 2019
@charignon
#### Summary
446e061 
Before this PR when using `github-review` one can download PRs title, body and diff and insert top level and inline comments.
After this PR, one can get more information when performing a review, including, reviews from other people, inline comments and issues top-level comments (made by replying to a PR). It also opens future work to support reply to inline comments (#9)

It looks like this:
```diff
~ PR TITLE
~
~ PR body
~ on multiple line
~ @foo: a comment at the top level
~ Reviewed by @Babar[APPROVED]: LGTM (a review comment)
<actual diff>
```

#### Progress
This is really rough work in progress, docstrings aren't final and this isn't fully tested.
- [X] Top level, issue comments
- [X] Reviews state and summary
- [ ] Inline comments (moved to another Change)

#### Test Plan
- [X] Add testing to start-review for new types of comments
- [X] Test end to end with multiple scenarios

This will enable adding new functionality like showing previous inline
and top level comments.
@charignon
Copy link
Owner Author

This is an extension of the work in #5

@wandersoncferreira wandersoncferreira mentioned this issue Oct 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charignon