Show top level comments and reviews #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example of what that looks like: I will open another issue for the line ending problem. This also makes me think we should have a mode (derived from diff) for highlighting the usernames and make it more readable. |
charignon
force-pushed
the
lc--add-top-level-comments-by-others
branch
from
8f46916 to
b4592dc
Compare
charignon
force-pushed
the
lc--add-top-level-comments-by-others
branch
from
b4592dc to
0b97d91
Compare
|
I gated this feature behind the flag |
Before this PR when using `github-review` one can download PRs title, body and diff and insert top level and inline comments. After this PR, one can get more information when performing a review, including, reviews from other people, inline comments and issues top-level comments (made by replying to a PR). It also opens future work to support reply to inline comments (#9) It looks like this: ```diff ~ PR TITLE ~ ~ PR body ~ on multiple line ~ @foo: a comment at the top level ~ Reviewed by @Babar[APPROVED]: LGTM (a review comment) <actual diff> ``` #### Progress This is really rough work in progress, docstrings aren't final and this isn't fully tested. - [X] Top level, issue comments - [X] Reviews state and summary - [ ] Inline comments (moved to another Change) #### Test Plan - [X] Add testing to start-review for new types of comments - [X] Test end to end with multiple scenarios This will enable adding new functionality like showing previous inline and top level comments.
charignon
force-pushed
the
lc--add-top-level-comments-by-others
branch
from
0b97d91 to
446e061
Compare
charignon
changed the title
charignon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this PR when using
github-reviewone can download PRs title, body and diff and insert top level and inline comments.After this PR, one can get more information when performing a review, including, reviews from other people, inline comments and issues top-level comments (made by replying to a PR). It also opens future work to support reply to inline comments (#9)
It looks like this:
Progress
This is really rough work in progress, docstrings aren't final and this isn't fully tested.
Test Plan