feat(ui): add minimize keybinding to diff permission dialogs#3192
Open
jan-xyz wants to merge 2 commits into
Open
feat(ui): add minimize keybinding to diff permission dialogs#3192jan-xyz wants to merge 2 commits into
jan-xyz wants to merge 2 commits into
Conversation
Adds an 'm' keybinding to permission dialogs that show a diff (edit, write, multi-edit). Pressing 'm' hides the dialog entirely and replaces the editor input area with a '⚠ Permission pending · press m to restore diff view' banner, letting users scroll through the chat history to review context before deciding. Pressing 'm' again restores the full permission dialog. While minimized, only scroll keys and 'm' are active; all other keys are blocked to prevent accidental input while a permission is pending. 💘 Generated with Crush Assisted-by: Crush:eu.anthropic.claude-sonnet-4-6 Co-authored-by: eu.anthropic.claude-sonnet-4-6 via Crush <charmcrush@users.noreply.github.com>
Co-authored-by: claude-sonnet-4-6 via Crush <charmcrush@users.noreply.github.com>
jan-xyz
force-pushed
the
feat/diff-view-minimize
branch
from
694b3ad to
4135ba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Crush asks for permission to edit a file, the diff view takes over the entire screen. There's no way to scroll back through the conversation to check context — what the agent was trying to do, what files it already touched — before deciding to allow or deny. This makes it hard to make an informed decision, especially in longer sessions.
This adds an
mkeybinding to diff permission dialogs (edit, write, multi-edit) that completely hides the dialog and gives back the full chat view. While minimized, the editor input is replaced by a⚠ Permission pendingbanner so the state is always visible, and only scroll keys are active — typing is intentionally blocked since a decision is still pending. Pressingmagain restores the dialog exactly as it was.AI attribution: Claude Sonnet (eu.anthropic.claude-sonnet-4-6) via Crush.