feat: allow multi-character corners on borders#695
Open
toller892 wants to merge 1 commit into
Open
Conversation
Remove the single-rune truncation on border corners (TopLeft, TopRight, BottomLeft, BottomRight). The renderHorizontalEdge function already uses ansi.StringWidth to correctly account for multi-character strings, so the truncation was unnecessary. This enables use cases like extended corner decorations: ┌── ── ┐ │ │ └── ── ┘ Fixes charmbracelet#605
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the single-rune truncation on border corners (
TopLeft,TopRight,BottomLeft,BottomRight).Currently,
applyBordertruncates all corner strings to a single rune (lines 406-410 inborders.go):This prevents users from using multi-character corner decorations. However, the
renderHorizontalEdgefunction already usesansi.StringWidthto correctly handle multi-character left/right parts, so the truncation is unnecessary.What changed
applyBorderExample
With this change, you can create borders like:
Using a custom border:
Fixes #605