Convert Connect to Scoutgame #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/scoutgame-app
mattcasey
reviewed
Aug 20, 2024
mattcasey
requested changes
Aug 20, 2024
There was a problem hiding this comment.
I noticed at least these things TODO:
- update the _env_vars.config file
- add a new deploy .yml file which uses a new ECR image and deploys to staging when "deploy-scoutsgame 🚀" tag is applied
- Create a new staging env to test that everyone was done correctly
- Update destroy_staging.yml so that it tears down the new staging env once PR's are merged
…into feat/scoutgame-app
…into feat/scoutgame-app
github-actions
bot
temporarily deployed
to
stg-scoutgame-4461-feat-scoutgame-app
mattcasey
approved these changes
Aug 21, 2024
…into feat/scoutgame-app
github-actions
bot
temporarily deployed
to
stg-scoutgame-4461-feat-scoutgame-app
github-actions
bot
temporarily deployed
to
stg-scoutgame-4461-feat-scoutgame-app
github-actions
bot
temporarily deployed
to
stg-scoutgame-4461-feat-scoutgame-app
…into feat/scoutgame-app
…p.charmverse.io into feat/scoutgame-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.