Fix/missing user #4472
Merged
Fix/missing user #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcasey
reviewed
Aug 21, 2024
| updatedBy: userId, | ||
| userId: member.userId, | ||
| // This is necessary because some test data fids do not have a corresponding farcaster profile | ||
| name: member.name || '', | ||
| farcasterId: member.farcasterId | ||
| name: member.account.displayName || member.account.username, |
There was a problem hiding this comment.
@motechFR please trim these values, this wouldn't fix the name which we got, which was was " "
mattcasey
reviewed
Aug 21, 2024
| import { getFarcasterUsers } from '@root/lib/farcaster/getFarcasterUsers'; | ||
| import { uid } from '@root/lib/utils/strings'; | ||
| import { isTruthy } from '@root/lib/utils/types'; | ||
| import { meanBy } from 'lodash'; |
mattcasey
reviewed
Aug 21, 2024
| ) | ||
| ).filter(isTruthy); | ||
| const projectMembers = await Promise.all( | ||
| newProjectMembers.map(async (member) => ensureFarcasterUserExists({ fid: member.farcasterId })) |
mattcasey
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Reliably ensure we upsert farcaster user in the form
WHY