Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show deleted properties for milestones #5179

Merged
merged 1 commit into from
Feb 12, 2025
Merged

show deleted properties for milestones #5179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/common/DatabaseEditor/components/table/tableHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
if (template.name !== tempName) {
setTempName(template.name);
}
}, [template.name]);

Check warning on line 102 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test apps 

React Hook useEffect has a missing dependency: 'tempName'. Either include it or remove the dependency array

Check warning on line 102 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test app 

React Hook useEffect has a missing dependency: 'tempName'. Either include it or remove the dependency array

Check warning on line 102 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test apps 

React Hook useEffect has a missing dependency: 'tempName'. Either include it or remove the dependency array

const popoverToggle = bindToggle(popupState);
const popoverToggleProps: typeof popoverToggle = {
Expand Down Expand Up @@ -139,7 +139,7 @@
width = textWidth + padding;
}
props.onAutoSizeColumn(_templateId, width);
}, []);

Check warning on line 142 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test apps 

React Hook React.useCallback has missing dependencies: 'columnRef' and 'props'. Either include them or remove the dependency array. However, 'props' will change when *any* prop changes, so the preferred fix is to destructure the 'props' object outside of the useCallback call and refer to those specific props inside React.useCallback

Check warning on line 142 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test app 

React Hook React.useCallback has missing dependencies: 'columnRef' and 'props'. Either include them or remove the dependency array. However, 'props' will change when *any* prop changes, so the preferred fix is to destructure the 'props' object outside of the useCallback call and refer to those specific props inside React.useCallback

Check warning on line 142 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test apps 

React Hook React.useCallback has missing dependencies: 'columnRef' and 'props'. Either include them or remove the dependency array. However, 'props' will change when *any* prop changes, so the preferred fix is to destructure the 'props' object outside of the useCallback call and refer to those specific props inside React.useCallback

let className = 'octo-table-cell header-cell disable-drag-selection';
if (isOver) {
Expand Down Expand Up @@ -336,6 +336,7 @@
component='span'
variant='subtitle1'
sx={{
textDecoration: template.deletedAt ? 'line-through' : undefined,
textOverflow: 'ellipsis',
overflow: 'hidden',
whiteSpace: 'nowrap'
Expand All @@ -352,7 +353,7 @@
)}
</Label>
),
[sorted, name, type]

Check warning on line 356 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test apps 

React Hook useMemo has missing dependencies: 'readOnly', 'reverseSort', 'template.deletedAt', and 'template.tooltip'. Either include them or remove the dependency array

Check warning on line 356 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test app 

React Hook useMemo has missing dependencies: 'readOnly', 'reverseSort', 'template.deletedAt', and 'template.tooltip'. Either include them or remove the dependency array

Check warning on line 356 in components/common/DatabaseEditor/components/table/tableHeader.tsx

View workflow job for this annotation

GitHub Actions / Test apps 

React Hook useMemo has missing dependencies: 'readOnly', 'reverseSort', 'template.deletedAt', and 'template.tooltip'. Either include them or remove the dependency array
);

return (
Expand Down
4 changes: 3 additions & 1 deletion lib/rewards/blocks/views.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,11 @@ export function getProposalRewardsView({
}) {
const view = getDefaultView({ spaceId });

const blockCreated = new Date(board.createdAt).toISOString();

// all custom properties are visible by default
view.fields.visiblePropertyIds = (board.fields.cardProperties as { id: string; deletedAt?: string }[])
.filter((p) => !p.deletedAt)
.filter((p) => !p.deletedAt || p.deletedAt > blockCreated)
.map((p) => p.id)
.filter((id: string) => {
if (rewardTypes.includes('custom') && (id === REWARD_CUSTOM_VALUE || id === DUE_DATE_ID)) {
Expand Down
15 changes: 15 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading